Files
balanceboard/tests/conftest.py
Chelsea 6cf35ca034 Phase 1-3 + 6: pluggable filter system, app factory, test harness
Implements the parallel.md workstreams (Agents A-E) toward REFACTOR_GOAL.md.

Phase 1 — app factory + blueprints + /api/v1:
- app.py -> create_app() factory (no module-level app); entrypoints updated
- routes/ (auth, pages, settings, admin, assets) + blueprints/api.py at /api/v1
- config.py / extensions.py / security.py extracted; services/ layer added
- endpoint names preserved so template url_for() calls keep resolving
  (static check: all 27 template url_for endpoints are defined routes)

Phase 2 — one pluggable filter system:
- filter_pipeline/registry.py: @register_stage / @register_plugin + discover_modules
- engine._init_stages() instantiates registered stages (no hardcoded dict);
  process_batch is AI-aware: only short-circuits to the AI-disabled path when
  a filterset's stages declare requires_ai, so offline filtersets run with AI off
- BaseFilterPlugin gets a consumer (stages/plugins.py); Keyword/Quality
  re-enabled via filter_config.json plugins config
- comment tree modes ported to stages/comment_filter.py + shared rules.py;
  wired into /api/v1/posts/<uuid> and /api/v1/comments/<uuid> via
  FilterEngine.filter_comments() (fails open)
- offline quality_filter filterset exercises plugins+ranker without AI
- legacy filter_lib / comment_lib / html_generation_lib / generate_html /
  active_html path deleted

Phase 3 prep — pluggable fetchers + Postgres models:
- Post / Comment SQLAlchemy models added to models.py
- migrate_content_to_db.py backfill (idempotent by uuid, batched, --dry-run)
- platforms/ fetcher registry (extension point)
- live reads/writes still go through PostService (disk JSON); cutover deferred

Phase 6 — test harness:
- pytest.ini + tests/ (conftest with in-memory SQLite fixture, no Postgres;
  stubbed polling/filter singletons)
- test_app_factory.py (route registration, no module-level app),
  test_api_contracts.py (posts/post_detail/comments/filters shape with
  monkeypatched post_service + get_filter_engine),
  test_filter_pipeline.py + test_plugin_contract.py (Flask-free; validated
  locally 12/12 incl. drop-in stage/plugin discovered with zero core edits)

Other: .gitignore added (__pycache__, data/, secrets); pytest in requirements.

Verification: py_compile clean across the project; the Flask-free filter-pipeline
and plugin-contract tests pass locally. App-factory / API-contract tests need
deps+docker to run; runtime flask routes / Auth0-repeated-create_app also gated
on docker.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-03 02:29:46 -05:00

112 lines
3.1 KiB
Python

"""Shared pytest fixtures for BalanceBoard.
The app fixture runs against an in-memory SQLite database (no Postgres
required) by monkeypatching ``database.init_db``. Filter-engine and
polling-service singletons are stubbed so request handlers do not start
background threads or hit the real filter pipeline during API contract
tests.
"""
import pytest
from sqlalchemy.pool import StaticPool
def _sqlite_init_db(app):
"""Replace the Postgres init_db with an in-memory SQLite setup."""
from database import db
app.config["SQLALCHEMY_DATABASE_URI"] = "sqlite:///:memory:"
# A single in-memory DB shared across the test's connections.
app.config["SQLALCHEMY_ENGINE_OPTIONS"] = {"poolclass": StaticPool}
app.config["SQLALCHEMY_TRACK_MODIFICATIONS"] = False
db.init_app(app)
with app.app_context():
db.create_all()
@pytest.fixture
def app(monkeypatch):
import database
from app import create_app
monkeypatch.setattr(database, "init_db", _sqlite_init_db)
application = create_app()
application.config.update(TESTING=True)
return application
@pytest.fixture
def client(app):
return app.test_client()
class _StubPolling:
"""No-op polling service so ``before_request`` does not start threads."""
def init_app(self, app):
pass
def start(self):
pass
class _StubFilterEngine:
"""Passthrough filter engine for API contract tests."""
class _Config:
def get_filterset(self, name):
return None
config = _Config()
def apply_filterset(self, posts, filterset_name="no_filter", use_cache=True):
for p in posts:
p.setdefault("_filter_score", 0.5)
p.setdefault("_filter_categories", [])
p.setdefault("_filter_tags", [])
return posts
def filter_comments(self, comments, filterset_name="no_filter"):
return comments
def get_available_filtersets(self):
return ["no_filter"]
@pytest.fixture
def stub_services(app, monkeypatch):
"""Patch the app's lazy service accessors so requests stay hermetic."""
import app as app_module
monkeypatch.setattr(app_module, "get_filter_engine", lambda: _StubFilterEngine())
monkeypatch.setattr(app_module, "get_polling_service", lambda: _StubPolling())
return app
class StubPostService:
"""In-memory post/comment store for /api/v1 contract tests."""
def __init__(self, posts=None, comments=None):
self._posts = posts or {}
self._comments = comments or {}
def load(self):
return self._posts, self._comments
@staticmethod
def build_comment_tree(comments):
comment_dict = {c["uuid"]: {**c, "replies": []} for c in comments}
roots = []
for c in comments:
parent = c.get("parent_comment_uuid")
if parent and parent in comment_dict:
comment_dict[parent]["replies"].append(comment_dict[c["uuid"]])
else:
roots.append(comment_dict[c["uuid"]])
return roots
def source_counts(self):
return {}
def latest_content_mtime(self):
return 0